Start shared containers in postProcessTestInstance for PER_CLASS lifecycle#11703
Open
remal wants to merge 1 commit intotestcontainers:mainfrom
Open
Start shared containers in postProcessTestInstance for PER_CLASS lifecycle#11703remal wants to merge 1 commit intotestcontainers:mainfrom
remal wants to merge 1 commit intotestcontainers:mainfrom
Conversation
…cycle With PER_CLASS, postProcessTestInstance runs before beforeAll. This change starts shared containers early so they are available in non-static @MethodSource factory methods and other TestInstancePostProcessor extensions. StoreAdapter now implements Startable with synchronized idempotent start/stop to support Startables.deepStart() and prevent redundant container lifecycle calls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When using
@TestInstance(PER_CLASS)with frameworks like Spring Boot, Quarkus, Micronaut, or others, non-static@MethodSourcefactory methods may call framework beans that depend on static@Containerfields to produce arguments for parameterized tests. These factory methods run afterpostProcessTestInstancebut beforebeforeEach, so containers must be started earlier thanbeforeAll.With
PER_CLASS,postProcessTestInstanceis called exactly once (same asbeforeAll), making it a suitable alternative for starting shared containers. This change moves shared container startup intopostProcessTestInstanceforPER_CLASSlifecycle, making them available during non-static@MethodSourceresolution and for otherTestInstancePostProcessorextensions.Example